dnd: Don't leak a signal connection

The handler is currently leaked when a drag monitor stops a
motion event.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2770>

diff --git a/js/ui/dnd.js b/js/ui/dnd.js
index c9bce01f54259cb330e522bbb0c86571a97fdd41..53b4fde6c04709fe07c000b6ee3a24749e70dd3b 100644 (file)
--- a/js/ui/dnd.js
+++ b/js/ui/dnd.js
@@ -590,6 +590,7 @@ var _Draggable = class _Draggable extends Signals.EventEmitter {
                 let result = motionFunc(dragEvent);
                 if (result != DragMotionResult.CONTINUE) {
                     global.display.set_cursor(DRAG_CURSOR_MAP[result]);
+                    dragEvent.targetActor.disconnect(targetActorDestroyHandlerId);
                     return GLib.SOURCE_REMOVE;
                 }
             }